Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2.4] [WIP] Respect custom connections when creating database #244

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

stancl
Copy link
Member

@stancl stancl commented Dec 11, 2019

Resolves #242

There might still be an issue with tenant identification, but this (f58591a) should fix the database creation.

@stancl stancl self-assigned this Dec 11, 2019
@archtechx archtechx deleted a comment from codecov bot Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #244 into 2.x will decrease coverage by 0.37%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #244      +/-   ##
============================================
- Coverage     88.02%   87.64%   -0.38%     
- Complexity      373      377       +4     
============================================
  Files            58       58              
  Lines          1094     1101       +7     
============================================
+ Hits            963      965       +2     
- Misses          131      136       +5
Impacted Files Coverage Δ Complexity Δ
...nantDatabaseManagers/PostgreSQLDatabaseManager.php 80% <0%> (-20%) 5 <1> (+1)
...rc/TenantDatabaseManagers/MySQLDatabaseManager.php 83.33% <0%> (-16.67%) 5 <1> (+1)
src/DatabaseManager.php 91.54% <80%> (-1.1%) 29 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5145b1f...f58591a. Read the comment docs.

@stancl stancl merged commit fed8c0f into 2.x Dec 11, 2019
@stancl stancl deleted the respect-custom-connection branch December 11, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double database when using custom server connection
1 participant